🐛 OCPBUGS-78092: fix: stale deprecation conditions after ClusterExtension upgrade#2590
Open
camilamacedo86 wants to merge 1 commit intooperator-framework:mainfrom
Open
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Refresh deprecation status after a successful apply so that upgrading from a deprecated bundle to a non-deprecated one clears Deprecated and BundleDeprecated conditions in the same reconciliation cycle. Generated-by: Cursor/Claude
camilamacedo86
force-pushed
the
fix-refresh-deprecate-status
branch
from
cb1e03d to
5b0ea47
Compare
camilamacedo86
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2590 +/- ##
==========================================
+ Coverage 67.78% 67.84% +0.05%
==========================================
Files 137 137
Lines 9574 9578 +4
==========================================
+ Hits 6490 6498 +8
+ Misses 2585 2583 -2
+ Partials 499 497 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When upgrading a ClusterExtension from a deprecated bundle (for example v1.0.1) to a non-deprecated bundle (for example v1.0.3), the deprecation conditions stay wrong.
Why this happens:
Solution
After a successful apply (when rollout is done):
We also store the deprecation data in reconcile state so it can be reused after apply.
Before
Reconcile:
Status:
install.bundle: v1.0.3 ✅ correct
Deprecated: True ("v1.0.1...") ❌ wrong
BundleDeprecated: True ❌ wrong
After
Reconcile:
→ refresh deprecation using new bundle
Status:
install.bundle: v1.0.3 ✅ correct
Deprecated: False ✅ correct
BundleDeprecated: False ✅ correct
Note
This fix is only for the Helm path.
For Boxcutter path, no change is needed: